svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke...

[Kubilay Kocak]

On 11/08/2014 5:50 PM, Max Brazhnikov wrote:
> On Sun, 10 Aug 2014 16:44:16 +0000 Alexey Dokuchaev wrote:
>> On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote:
>>> On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote:
>>>> On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote:
>>>>> New Revision: 364518
>>>>> URL: http://svnweb.freebsd.org/changeset/ports/364518
>>>>> QAT: https://qat.redports.org/buildarchive/r364518/
>>>>>
>>>>> -USES=		pkgconfig
>>>>> +USES=		pkgconfig python:2
>>>>>  USE_GNOME=	atk
>>>>> -USE_PYTHON=	2
>>>>> -USE_PYDISTUTILS=yes
>>>>> -PYDISTUTILS_AUTOPLIST=	yes
>>>>> +PYTHON_FEATURES=autoplist distutils
>>>>
>>>> Yuck, this PYTHON_FEATURES knob is ugly.  Why not follow Perl's example
>>>> instead (USES=perl and USE_PERL)?  It both makes more sense and shorter.
>>>
>>> ugly or not, it's a matter of taste. [...]
>>
>> Not really.  It is also 1) inconsistent with USE_PERL, and 2) is overly
>> long knob name (breaks indentation).
> 
> 1)
> I don't think USE_PERL is worthy of comparison, USE_XXX
> shouldn't be used after conversion to USES:
> - it complicates the transition
> - it's inconsistent with other old style USE_YXZ
> 
> I'd like to see something like XXX_COMPONENTS for this,
> but it is too long :)

Sounds like we want something that describes foo's *ports framework*
bits rather than foo's bits, which neither FOO_FEATURES nor
FOO_COMPONENTS seems to indicate. USE_FOO is less ambiguous, but not
perfect, and feels better given it is a verb, connecting its use
semantically to the value(s) specified.

Without having to inventing a new one without a good warrant to do so,
USE_FOO is clean and has an existing implementer. Downside of course is
that it's in use, though that's insufficient justification not to use it
however.

> 2) I'd prefer broken indentation to clear meaning.

I like clean indentation too. USE_PYDISTUTILS makes for lots of
cognitive dissonance at the moment ;)

If we can do functional, obvious *and* beautiful, we ought to put in the
few extra cycles to do so.

koobs