svn commit: r363361 - in head/editors/fte: . files
Antoine Brodin
antoine at FreeBSD.org
Fri Aug 1 06:02:23 UTC 2014
On Fri, Aug 1, 2014 at 7:16 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Wed, Jul 30, 2014 at 06:13:48PM +0200, John Marino wrote:
>> On 7/30/2014 18:08, Alexey Dokuchaev wrote:
>> > Given some thought over it, I propose the following changes to makepatch:
>> >
>> > - default to dash (minus, '-')
>> > - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR)
>> > to override it when needed
>> > - assert that forced value is not something insane ('__', '::', '../../',
>> > etc.) -- basically, match it over a prerefined list of acceptable values
>> >
>> > I can cook up a patch unless John had beaten me on that already.
>>
>> Nope, go for it.
>
> Have a look (attached). I've also fixed annoying bug (appending of leading
> "./" in the ---/+++ lines of generated patches), and improved the comment.
Hi,
Refusing _ in seperator seems total bullshit, this convention has
been in place for 9 years, wtf!?
Cheers,
Antoine
More information about the svn-ports-all
mailing list