svn commit: r352093 - head/x11/startup-notification

[Baptiste Daroussin]

On Fri, Apr 25, 2014 at 11:13:27AM +0200, Tijl Coosemans wrote:
> On Fri, 25 Apr 2014 07:38:02 +0000 (UTC) Baptiste Daroussin wrote:
> > Author: bapt
> > Date: Fri Apr 25 07:38:01 2014
> > New Revision: 352093
> > URL: http://svnweb.freebsd.org/changeset/ports/352093
> > QAT: https://qat.redports.org/buildarchive/r352093/
> > 
> > Log:
> >   Switch to USES=libtool
> >   Strip binaries
> > 
> > Modified:
> >   head/x11/startup-notification/Makefile
> >   head/x11/startup-notification/pkg-plist
> > 
> > Modified: head/x11/startup-notification/Makefile
> > ==============================================================================
> > --- head/x11/startup-notification/Makefile	Fri Apr 25 07:34:14 2014	(r352092)
> > +++ head/x11/startup-notification/Makefile	Fri Apr 25 07:38:01 2014	(r352093)
> > @@ -4,7 +4,7 @@
> >  
> >  PORTNAME=	startup-notification
> >  PORTVERSION=	0.12
> > -PORTREVISION=	1
> > +PORTREVISION=	2
> >  CATEGORIES=	x11 gnome
> >  MASTER_SITES=	http://www.freedesktop.org/software/startup-notification/releases/
> >  DIST_SUBDIR=	gnome2
> > @@ -12,16 +12,15 @@ DIST_SUBDIR=	gnome2
> >  MAINTAINER=	gnome at FreeBSD.org
> >  COMMENT=	Library that supports startup notification spec from freedesktop.org
> >  
> > -LIB_DEPENDS=	xcb-util:${PORTSDIR}/x11/xcb-util
> > +LIB_DEPENDS=	libxcb-util.so:${PORTSDIR}/x11/xcb-util
> >  
> >  USE_XORG=	x11
> > -USE_AUTOTOOLS=	libtool
> > -USES=		gmake pathfix pkgconfig
> > -USE_GNOME=	ltasneededhack
> > +USES=		gmake libtool pathfix pkgconfig
> >  GNU_CONFIGURE=	yes
> >  USE_LDCONFIG=	yes
> >  CPPFLAGS+=	-I${LOCALBASE}/include
> >  LDFLAGS+=	-L${LOCALBASE}/lib
> >  CONFIGURE_ARGS+=ac_cv_lib_ICE_IceConnectionNumber=no
> > +INSTALL_TARGET=	install-strip
> >  
> >  .include <bsd.port.mk>
> > 
> > Modified: head/x11/startup-notification/pkg-plist
> > ==============================================================================
> > --- head/x11/startup-notification/pkg-plist	Fri Apr 25 07:34:14 2014	(r352092)
> > +++ head/x11/startup-notification/pkg-plist	Fri Apr 25 07:38:01 2014	(r352093)
> > @@ -5,9 +5,9 @@ include/startup-notification-1.0/libsn/s
> >  include/startup-notification-1.0/libsn/sn-util.h
> >  include/startup-notification-1.0/libsn/sn.h
> >  lib/libstartup-notification-1.a
> > -lib/libstartup-notification-1.la
> >  lib/libstartup-notification-1.so
> >  lib/libstartup-notification-1.so.0
> > +lib/libstartup-notification-1.so.0.0.0
> >  libdata/pkgconfig/libstartup-notification-1.0.pc
> >  @dirrm include/startup-notification-1.0/libsn
> >  @dirrm include/startup-notification-1.0
> 
> It's probably better to use libtool:keepla here.  There are too many
> ports that depend on this port with .la files that may refer to
> libstartup-notification-1.la.
> 
> I've been thinking if it would be possible for pkg to register .la files
> (and their references to other libraries) like it does with .so files.
> Then you could find out if there are references lurking in other ports
> with pkg rquery.
> 

Concerning gnome related ports like this one I'm pretty confident about removing
the .la as upstream jhbuild continuous integration system expect everything to
be install without .la, so almost nothing should expect to find the .la here.

concerning registering the .la that will be quite complicated because as far as
I know, no trace of .la is left inside the resulted binaries, but if you think
about a clever way, I'm not against it :)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140425/ee47368d/attachment.sig>