svn commit: r351606 - head/net/netatalk

Alexey Dokuchaev danfe at FreeBSD.org
Sun Apr 20 14:48:33 UTC 2014


On Sat, Apr 19, 2014 at 07:07:42PM +0000, Joe Marcus Clarke wrote:
> New Revision: 351606
> URL: http://svnweb.freebsd.org/changeset/ports/351606
> QAT: https://qat.redports.org/buildarchive/r351606/
> 
> Log:
>   * Convert to STAGE
>   * Only enable AppleTalk support on versions of FreeBSD that support it [1]
>   
> [...]
> +APPLETALK_DESC=	AppleTalk protocol support (where supported)

This change is bogus.  You could've simply make this option conditional.  For
example, cf. games/doomlegacy:

.if exists(/usr/include/netipx/ipx.h)
OPTIONS_DEFINE+=	IPX
IPX_DESC=	IPX protocol support
.endif

> -.if ${PORT_OPTIONS:MAPPLETALK}
> +.if ${OSVERSION} < 1100013 && ${PORT_OPTIONS:MAPPLETALK}

Is it possible to use exists() here instead of OSVERSION?  We're generally
trying to get rid of OSVERSION checks...

./danfe


More information about the svn-ports-all mailing list