svn commit: r328251 - in head/audio/pianobar: . files

Alexey Dokuchaev danfe at FreeBSD.org
Mon Sep 30 21:35:53 UTC 2013


On Fri, Sep 27, 2013 at 03:53:44PM +0400, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe at FreeBSD.org) wrote:
> > > That does not matter.
> > 
> > Technically it does not, but as I said, it's better to have them still.
> 
> For which reason?

Quoting someone, perhaps Michael Scherbakov, "and if one needs an
explanation, there is really nothing to explain".  ;-)

> > > There were none, see PR.
> > 
> > So why the header change was comitted then?
> 
> Because it was in the PR.

Submitters can make mistakes at times; that's why we need committers: so
crap from the PR remains in the PR, not in the repo.  Noise-only changes
should not be committed without sufficient reason.

./danfe


More information about the svn-ports-all mailing list