svn commit: r327601 - head/Mk

Brendan Fabeny bf1783 at gmail.com
Sat Sep 21 13:43:56 UTC 2013


On 9/21/13, Sunpoet Po-Chuan Hsieh <sunpoet at freebsd.org> wrote:
> On Sat, Sep 21, 2013 at 12:07 AM, Baptiste Daroussin
> <bapt at freebsd.org>wrote:
>
>> On Fri, Sep 20, 2013 at 05:27:18PM +0200, Pietro Cerutti wrote:
>> >
>> > On 20-set-2013, at 10:32, Sunpoet Po-Chuan Hsieh <sunpoet at FreeBSD.org>
>> wrote:
>> >
>> > > Hi Bapt,
>> > >
>> > > May I suggest to change hard-coded sleep time to a settable variable
>> defaults to 10? It would save time while checking multiple ports with
>> terminal outputs redirected to a log file.
>> >
>> > Definitely +1
>> >
>> I would be all for it, send me a patch and I will approve :)
>>
>> regards,
>> Bapt
>>
>
> A simple patch is here [1]. Thanks.
>
> [1] http://people.FreeBSD.org/~sunpoet/bsd.port.mk-sleep.patch

It seems to me that having more than one configurable wait variable is
overkill: there should be one and it should also cover the sleep in
identify-install-conflicts; and it should default to 0 when BATCH or
PACKAGE_BUILDING is set.

I also do not think we should bother to include bsd.sanity.mk when
DEVELOPER isn't set -- it is needless added work.

b.


More information about the svn-ports-all mailing list