svn commit: r327440 - in head/irc/hexchat: . files

[Koop Mast]

On 17-9-2013 9:51, Rusmir Dusko wrote:
>> On 16-9-2013 22:55, Rusmir Dusko wrote:
>>>    .if ! ${PORT_OPTIONS:MLIBSEXY} && ! ${PORT_OPTIONS:MGTKSPELL} && ! ${PORT_OPTIONS:MSTATIC}
>>>    CONFIGURE_ARGS+=--enable-spell=none
>>>    .endif
>>>    
>>> +.if ${PORT_OPTIONS:MLIBSEXY} || ${PORT_OPTIONS:MGTKSPELL} || ${PORT_OPTIONS:MSTATIC}
>>> +RUN_DEPENDS+=aspell:${PORTSDIR}/textproc/en-aspell
>>> +.endif
>>> +
>>>    .if ${PORT_OPTIONS:MSTATIC}
>>>    CONFIGURE_ARGS+=--enable-spell=static
>>>    .endif
>> Shouldn't this be textproc/aspell ? The aspell binary is in that port
>> and en-aspell only has EN dictionaries etc.
> For test I have deleted all aspell Ports
>
> pkg info | grep aspell
>
> nothing
>
> /usr/ports/textproc/aspell/ ; make reinstall
>
> pkg info | grep aspell
> aspell-0.60.6.1_2              Spelling checker with better suggestion logic than ispell
>
> pkg delete -f aspell-0.60.6.1_2
>
> Also is needed to install textproc/en-aspell which install textproc/aspell
>
> /usr/ports/textproc/en-aspell ; make reinstall
>
> pkg info | grep aspell
> aspell-0.60.6.1_2              Spelling checker with better suggestion logic than ispell
> en-aspell-7.1.0_1              Aspell English dictionaries
Fair enough if you want to install a dictionairy, I'm of the opinion 
that the uses needs to have the choice which dictionaries he wants to 
install.
But my point is that the RUN_DEPEND line is wrong. The aspell binary is 
in the aspell port not en-aspell. If you want to depend on en-aspell you 
need to either check for a file from the en-aspell plist
RUN_DEPENDS+=${LOCALBASE}/share/aspell/english.alias:${PORTSDIR}/textproc/en-aspell
or check for the package
RUN_DEPENDS+=en-aspell>=0:${PORTSDIR}/textproc/en-aspell

-Koop