svn commit: r327257 - head/devel/cvsd

[Baptiste Daroussin]

On Sat, Sep 14, 2013 at 09:59:28AM +0000, Olli Hauer wrote:
> Author: ohauer
> Date: Sat Sep 14 09:59:28 2013
> New Revision: 327257
> URL: http://svnweb.freebsd.org/changeset/ports/327257
> 
> Log:
>   - fix r327153, cvs is only required
>     .if ${OSVERSION} > 1000000

As for the uucp thing, this is noop, cvs is required everywhere except that as
base already provides it on < 10.0 then /usr/bin/cvs will satisfy the
dependency.

Plus if somone do build 9.* WITHOUT_CVS and try to install cvsd it will fail.

The only thing that is satisfied by this OSVERSION checking is tinderbox because
tinderbox is failing at properly gather the dependency from *inside* the target!

crees is iirc working on the issue, but that is a tinderbox issue for very long.

If you want to satisfy both, probably the good direction if something like:
.if !exists(${DESTDIR}/usr/bin/cvs) || ${OSVERSION} > 1000000
The deps goes here
.endif

but imho that is lot of complexity to satisfy a tinderbox design issue.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130914/2d822c3e/attachment.sig>