svn commit: r331810 - in head: Mk/Uses archivers/lha archivers/lha-ac audio/mp3gain comms/vrflash converters/mpack emulators/vmw german/dtaus graphics/hobbes-icons-xpm irc/iroffer irc/iroffer-dinoe...

[Baptiste Daroussin]

On Mon, Oct 28, 2013 at 05:17:38AM -0500, Bryan Drewery wrote:
> On 10/27/2013 5:29 PM, Dirk Meyer wrote:
> > Author: dinoex
> > Date: Sun Oct 27 22:29:46 2013
> > New Revision: 331810
> > URL: http://svnweb.freebsd.org/changeset/ports/331810
> > 
> > Log:
> >   - use STAGEDIR
> >   - use OPTIONS_DEFINE
> > 
> > Added:
> >   head/Mk/Uses/manpages.mk   (contents, props changed)
> >   head/www/smb_auth/pkg-message   (contents, props changed)
> > Modified:
> >   head/archivers/lha-ac/Makefile
> >   head/archivers/lha/Makefile
> >   head/audio/mp3gain/Makefile
> >   head/comms/vrflash/Makefile
> >   head/converters/mpack/Makefile
> >   head/emulators/vmw/Makefile
> >   head/german/dtaus/Makefile
> >   head/graphics/hobbes-icons-xpm/Makefile
> >   head/irc/iroffer-dinoex/Makefile
> >   head/irc/iroffer-lamm/Makefile
> >   head/irc/iroffer/Makefile
> >   head/mail/noattach/Makefile
> >   head/mail/raysfilter/Makefile
> >   head/mail/ripmime/Makefile
> >   head/mail/sentinel/Makefile
> >   head/mail/sma/Makefile
> >   head/mail/vbsfilter/Makefile
> >   head/misc/estic/Makefile
> >   head/multimedia/replex/Makefile
> >   head/net-mgmt/bsnmp-jails/Makefile
> >   head/net-p2p/ed2k/Makefile
> >   head/net/sixxs-aiccu/Makefile
> >   head/net/tinyldap/Makefile
> >   head/news/pgpmoose/Makefile
> >   head/ports-mgmt/pkg_jail/Makefile
> >   head/security/pgp/Makefile
> >   head/security/pgpin/Makefile
> >   head/sysutils/dupmerge/Makefile
> >   head/sysutils/ua/Makefile
> >   head/sysutils/zidrav/Makefile
> >   head/textproc/agrep/Makefile
> >   head/www/smb_auth/Makefile
> >   head/www/tidy/Makefile
> > 
> > Added: head/Mk/Uses/manpages.mk
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/Mk/Uses/manpages.mk	Sun Oct 27 22:29:46 2013	(r331810)
> > @@ -0,0 +1,120 @@
> > +# $FreeBSD$
> > +#
> > +# Provide support for manpages
> > +#
> > +# MAINTAINER: dinoex at FreeBSD.org
> > +#
> > +# Feature:              manpages
> > +# Usage:                USES=manpages or USES=manpages:ARGS
> > +# Valid ARGS:           install
> 
> Can you please revert this? This is not correct at all. portmgr has
> decided that manpages should be in the plist; you should not
> unilaterally decide to re-add a macro for it again.

+1!!

I already explained a couple of time why those macros are broken. It is really
painful to bring back the ports tree to a sane framework, so bringing back those
macro it just giving more pain to people doing the sanitizing work.

Even on ports having tons of manpages adding 10k lines in a plist or adding 10k
lines plus the magic to try to handle the macros directories in a Makefile is
the same work.

Plus now we have make makeplist and make check-orphans to easier that work.

Last even if you were going to that direction, it would have need:
1/ an argumented proposal to portmgr.
2/ a complete implementation (you have totally missed the mlinks part).

Uses is under Mk on purpose, it means it is under portmgr control, to add
something in Uses you should have portmgr approval.

This is also giving a lot of pain to an ongoing work to really have
NO_INSTALL_MANPAGE really working over the full ports tree.

bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20131028/ac615f12/attachment.sig>