svn commit: r331243 - head/sysutils/tmux

[Mathieu Arnold]

+--On 22 octobre 2013 15:55:20 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
wrote:
| On Tue, Oct 22, 2013 at 05:30:35AM -0500, Bryan Drewery wrote:
|> On 10/22/2013 4:06 AM, Mathieu Arnold wrote:
|> >  .if ${PORT_OPTIONS:MEXAMPLES}
|> > -	@${MKDIR} ${EXAMPLESDIR}
|> > -	@${INSTALL_DATA} ${WRKSRC}/examples/* ${EXAMPLESDIR}
|> > +	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
|> > +	@${INSTALL_DATA} ${WRKSRC}/examples/* ${STAGEDIR}${EXAMPLESDIR}
|> >  .endif
|> 
|> I think the general trend is to not hide any install commands since it
|> is touching the user's system, and is good for debugging build logs.
| 
| (Not just to Mathieu, writing this given another occasion.)
| 
| Yes, please, make installation commands vocal (muting mkdir's is optional,
| some people like it, it's okay).

I'll do that in the future :-)

| I would also like to mention that, unless DOCS/EXAMPLES require extra
| dependencies (e.g. Doxygen/DocBook) or just huge enough to create insane
| I/O load, for staged ports, you can remove those .if ${PORT_OPTIONS...}
| checks.  In many cases, it would collaterally allow to remove .include
| <bsd.port.options.mk> (when there are no other PORT_OPTIONS checks).

Well, I usually do that, but for other people's ports, when my main goal
was to convert to staging, I didn't want to touch too many other things :-)

-- 
Mathieu Arnold