svn commit: r331046 - head/Mk/Scripts

[Philip M. Gollucci]

+10,000 !


On Mon, Oct 21, 2013 at 9:41 AM, Eitan Adler <eadler at freebsd.org> wrote:

> On Mon, Oct 21, 2013 at 2:47 AM, Baptiste Daroussin <bapt at freebsd.org>
> wrote:
> > On Sun, Oct 20, 2013 at 03:01:38PM -0400, Eitan Adler wrote:
> >> On Sun, Oct 20, 2013 at 2:12 PM, Alex Kozlov <ak at freebsd.org> wrote:
> >> > Author: ak
> >> > Date: Sun Oct 20 18:12:49 2013
> >> > New Revision: 331046
> >> > URL: http://svnweb.freebsd.org/changeset/ports/331046
> >> >
> >> > Log:
> >> >   - Add check for suid files and directories
> >>
> >> Can you please add an in-port variable to disable this (NEEDS_SUID /
> >> NEEDS_ROOT) or remove this check?
> >>
> >> Warnings which may be ignored are not very useful.
> >>
> >
> > I do not think this is really a good way. First NEED_ROOT is a temporary
> knob
> > and should die as soon a possible as everything should be doable as a
> user.
>
> As I said to Alex privately,
>
> it should be possible to run check-sanity across the tree and get
> *zero* results.  If some warnings could be ignored people will start
> ignoring all of them or people will start to "fix" them incorrectly.
> Look at what happens with portlint warnings.
>
> There needs to be an in-port method of quieting bogus warnings.
>
>
> --
> Eitan Adler
> Source, Ports, Doc committer
> Bugmeister, Ports Security teams
>



-- 
---------------------------------------------------------------------------------------------
4096R/D1EAB94D 2081 E230 3001 6508 8847  1BBF A0A8 DB0F D1EA B94D
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
Member,                           Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Director IT Operations,      RideCharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.