svn commit: r330810 - head/Mk/Scripts

[Sunpoet Hsieh]

On Sat, Oct 19, 2013 at 8:17 AM, Baptiste Daroussin <bapt at freebsd.org>wrote:

> Author: bapt
> Date: Sat Oct 19 00:17:10 2013
> New Revision: 330810
> URL: http://svnweb.freebsd.org/changeset/ports/330810
>
> Log:
>   Recommand to use STRIP_CMD to strip binaries given that it will respect
> the WITH_DEBUG option
>
> Modified:
>   head/Mk/Scripts/qa.sh
>
> Modified: head/Mk/Scripts/qa.sh
>
> ==============================================================================
> --- head/Mk/Scripts/qa.sh       Sat Oct 19 00:14:22 2013        (r330809)
> +++ head/Mk/Scripts/qa.sh       Sat Oct 19 00:17:10 2013        (r330810)
> @@ -66,7 +66,7 @@ stripped() {
>         for f in `find ${STAGEDIR} -type f`; do
>                 output=`/usr/bin/file ${f}`
>                 case "${output}" in
> -               *:*\ ELF\ *,\ not\ stripped*) warn "${f} is not stripped";;
> +               *:*\ ELF\ *,\ not\ stripped*) warn "${f} is not stripped
> consider using \${STRIP_CMD}";;
>                 esac
>         done
>  }
> _______________________________________________
> svn-ports-all at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-ports-all
> To unsubscribe, send any mail to "svn-ports-all-unsubscribe at freebsd.org"
>

MAKE_ENV=       INSTALL_STRIP_FLAG=${STRIP}
is also a possible way which respects WITH_DEBUG.
Could this be added to qa.sh?

Regards,
sunpoet