svn commit: r330501 - head/deskutils/qrfcview

[Max Brazhnikov]

On Thu, 17 Oct 2013 23:22:56 +0400 Dmitry Marakasov wrote:
> * Max Brazhnikov (makc at freebsd.org) wrote:
> 
> > I suppose your c++ is actually g++
> 
> It may be, it may be not. Anyway, if g++ shows itself in the build,
> compiler is not respected. Another example:
> 
> % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1
> g++ -c -O2 -pipe -march=nocona ...
> 
> with my qmake.mk patch:
> 
> % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1
> ccache c++ -c -O2 -pipe -march=nocona ...
> 
> > > That's because QMAKEFLAGS contains QMAKE_CC and friends, but
> > > QMAKE_ARGS from Uses/qmake.mk doesn't.
> > 
> > it doesn't need to: compiler is already respected via QMAKESPEC,
> > QMAKE_CC, etc are redundant.
> 
> No, QMAKESPEC is just a bunch of hardcoded values - it respects nothing.

QMAKESPEC is set in accordance with CXX value, but I see your point,
so I propose the following patch
http://people.freebsd.org/~makc/patches/bsd.qt.mk.diff

btw, in case you have missed one of my previous mail, there is one more patch for you
http://people.freebsd.org/~makc/patches/qnetwalk.diff

Cheers,
Max