svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper...

[Jason Helfman]

Looks good to me, as well, and approved. The port was highly reliant on
PKGNAMESUFFIX changing before, however this is no longer the case.

Thanks!

-jgh

On Sat, Oct 12, 2013 at 12:09 PM, Chris Rees <crees at bayofrum.net> wrote:

> Looks fine to me, if Jason approves.
>
> Thanks also for the Python changes.
>
> Chris
>
>
>
> -----Original Message-----
> From: Sunpoet Po-Chuan Hsieh <sunpoet at FreeBSD.org>
> To: Jason Helfman <jgh at freebsd.org>, pgsql at freebsd.org
> Cc: ports-committers <ports-committers at freebsd.org>,
> svn-ports-all at freebsd.org, svn-ports-head at freebsd.org
> Sent: Sat, 12 Oct 2013 19:55
> Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client
> postgresql84-contrib postgresql84-docs postgresql84-server
> postgresql90-client postgresql90-contrib postgresql90-docs
> postgresql90-plper...
>
> Hi Jason and pgsql@ team,
>
> May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and
> portlint complains [1].
> I have prepared a patch [2] which contains 2 changes:
> 1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT}
> 2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports
> I have also checked PKGNAME is unchanged after applying this patch.
> Please review it.
> Thanks.
>
> [1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section.
> [2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch
>
> Regards,
> sunpoet
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>


-- 
Jason Helfman          | FreeBSD Committer
jgh at FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve