svn commit: r330124 - in head/ports-mgmt/portlint: . src

[Joe Marcus Clarke]

On 10/12/13 6:14 AM, Bryan Drewery wrote:
> Author: bdrewery
> Date: Sat Oct 12 10:14:41 2013
> New Revision: 330124
> URL: http://svnweb.freebsd.org/changeset/ports/330124
>
> Log:
>    - Update to 2.14.5
>
>    Changes:
>      * Fix recommending to replace USES=gmake with ${GMAKE} [1]
>      * Ignore USES when recommending to replace direct commands [1]
>      * Fix COMMENT check so it checks for length even if it
>        is not formatted properly [2]

Please don't do this again.  I maintain portlint locally, and I try to 
patch changes.  You could have asked about my plans instead of just 
grabbing the PRs.

Joe

>
>    PR:		ports/181359 [1]
>    Submitted by:	Alan Hicks <ahicks at p-o.co.uk> [1]
>    Reported by:	many
>    PR:		ports/181730 [2]
>    Submitted by:	gerald
>    Approved by:	maintainer timeout (> 1 month)
>
> Modified:
>    head/ports-mgmt/portlint/Makefile
>    head/ports-mgmt/portlint/src/portlint.pl
>
> Modified: head/ports-mgmt/portlint/Makefile
> ==============================================================================
> --- head/ports-mgmt/portlint/Makefile	Sat Oct 12 09:31:18 2013	(r330123)
> +++ head/ports-mgmt/portlint/Makefile	Sat Oct 12 10:14:41 2013	(r330124)
> @@ -2,7 +2,7 @@
>   # $FreeBSD$
>
>   PORTNAME=	portlint
> -PORTVERSION=	2.14.4
> +PORTVERSION=	2.14.5
>   CATEGORIES=	ports-mgmt
>   MASTER_SITES=	# none
>   DISTFILES=	# none
>
> Modified: head/ports-mgmt/portlint/src/portlint.pl
> ==============================================================================
> --- head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 09:31:18 2013	(r330123)
> +++ head/ports-mgmt/portlint/src/portlint.pl	Sat Oct 12 10:14:41 2013	(r330124)
> @@ -1157,11 +1157,11 @@ sub check_depends_syntax {
>   					"USES[+]=gettext.");
>   			}
>
> -			# check USE_GMAKE
> +			# check USES=gmake
>   			if ($m{'dep'} =~ /^(gmake|\${GMAKE})$/) {
>   				&perror("WARN", $file, -1, "dependency to $1 ".
>   					"listed in $j. consider using ".
> -					"USE_GMAKE.");
> +					"USES[+]=gmake.");
>   			}
>
>   			# check USE_QT
> @@ -1867,6 +1867,7 @@ ruby sed sh sort sysctl touch tr which x
>   				&& $curline !~ /^NO_CDROM(.)?=[^\n]+$i/m
>   				&& $curline !~ /^MAINTAINER(.)?=[^\n]+$i/m
>   				&& $curline !~ /^CATEGORIES(.)?=[^\n]+$i/m
> +				&& $curline !~ /^USES(.)?=[^\n]+$i/m
>   				&& $curline !~ /^WX_COMPS(.)?=[^\n]+$i/m
>   				&& $curline !~ /^\s*#.+$/m
>   				&& $curline !~ /\-\-$i/m
> @@ -2839,7 +2840,8 @@ MAINTAINER COMMENT
>   	} else { # check for correctness
>   		if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #"
>   			&perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period");
> -		} elsif (length($makevar{COMMENT}) > 70) {
> +		}
> +		if (length($makevar{COMMENT}) > 70) {
>   			&perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit.");
>   		}
>   	}
>


-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome