svn commit: r329928 - head/sysutils/hoz/files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Oct 9 21:58:00 UTC 2013


On Wed, Oct 09, 2013 at 11:01:17PM +0200, Baptiste Daroussin wrote:
> On Wed, Oct 09, 2013 at 08:44:15PM +0000, Jose Alonso Cardenas Marquez wrote:
> > New Revision: 329928
> > URL: http://svnweb.freebsd.org/changeset/ports/329928
> > 
> > Log:
> >   - Respect CC
> >   
> > +@@ -1,17 +1,16 @@
> > + 
> > +-CC = gcc
> > ++CC ?= gcc
> > + 
> >   OBJ = hoz.o hozgtk.o hozgtk_c.o hozgtk_i.o hozgtk_s.o hozcli.o
> >   LINKOBJ  = hoz.o hozcli.o
> >   GLINKOBJ  = hoz.o hozgtk.o hozgtk_c.o hozgtk_i.o hozgtk_s.o
> 
> the right fix here is 
> MAKE_ARGS+=	CC="${CC}"
> 
> not to patch upstream makefile

In this case I think it's OK, since the patch was already there.  It's nice
to have all changes grouped together; plus, shall upstream decide to pull
our fixes, working with a patch is easier than to find MAKE_ARGS line some-
where in port's own Makefile.

./danfe


More information about the svn-ports-all mailing list