svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files

[Baptiste Daroussin]

On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote:
> On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote:
> > I have attached a diff with the proposed changes covering all three
> > ports.  It's pretty straight-forward.
> >  
> >  .if ${PORT_OPTIONS:MREPLACE_BASE}
> > -.if ${OSVERSION} >= 1000500
> > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000500
> 
> Given that OSVERSION is used extensively in the tree, I'm worrying that
> adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less
> readable.  Wouldn't it make more sense to place this check somewhere in
> single place, and define whatever OSVERSION that looks reasonable when
> OPSYS == FreeBSD instead of patching every port?
> 
> ./danfe

except that lots/most of the osversion checking in the ports tree is also wrong
and was due to a design bug of pointyhat/tinderbox, pointyhat is gone, and
tinderbox had been fixed. there is no need anymore for most of them which also
are often wrong given the flexibility we have with buildworld.

I do plan to remove most of the useless osversion.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20131126/bb5e31ea/attachment.sig>