svn commit: r333807 - head/textproc/multimarkdown

[Baptiste Daroussin]

On Thu, Nov 14, 2013 at 11:31:10PM +0000, Adam Weinberger wrote:
> Author: adamw
> Date: Thu Nov 14 23:31:09 2013
> New Revision: 333807
> URL: http://svnweb.freebsd.org/changeset/ports/333807
> 
> Log:
>   Add an include-able file to facilitate checking out sources from git.
>   Useful especially for projects that don't have distfiles, or that use
>   submodules that don't have distfiles.
> 

Hi,

This port is full of issues with the ports tree and breaks lot of principle of
the ports tree.

1/ it depends on the https interface of github, meaning you need git compiled
with the CURL option, which not every body activates

2/ it has no distinfo to validate the distfiles so we have to garanty 2 people
building multimarkdown are building the same thing!

if upstream does 2 new commits then git tag -d <tag1> and git tag <tag1> then
you are doomed without noticing.

3/ all distfiles should be individually fetchable and storable.

We need to be able to have offline builders, and for them we need to be able to
feed them with distfiles by putting them into the distfiles directory of the
offline builder, this method totally kills that.

4/ it is using submodules meaning the revision of the bundle code is not known
meaning that any single packages can potentially be bundling different code
untested by the maintainer.

Somone should teach upstream how to make a release or we should not provide
packages for them.

The right way to handle this imho would be to properly use USE_GITHUB by
fetching the distfiles related to the commit/tag multimarkdown depends on

Then fetch the same way the distfiles of the submodules.

in post-extract move the content of the submodules into the final directory.

That should build.

I know you ask for advice on this, sorry I haven't find time to help earlier.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20131115/0096b8c1/attachment.sig>