svn commit: r332953 - head/benchmarks/nttcp

[Alexey Dokuchaev]

On Wed, Nov 06, 2013 at 01:55:14PM +0000, Ganael LAPLANCHE wrote:
> On Wed, 6 Nov 2013 08:18:15 +0000, Alexey Dokuchaev wrote
> 
> Hi Alexey,
> > >  ALL_TARGET=	nttcp
> > > -MAN1=		nttcp.1
> > > -PLIST_FILES=	bin/nttcp
> > > +PLIST_FILES=	bin/nttcp man/man1/nttcp.1.gz
> > 
> > We usually try to move out PLIST_* knobs in separate block.
> 
> You mean having a blank line between MAN1 and PLIST_FILES, right ?

Well, since now MAN1 line is gone, it would be blank line between ALL_TARGET
and PLIST_FILES.

> > > -	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/
> > > -	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/
> > > +	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/
> > > +	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/
> > 
> > Manual pages should be installed relative to MAN[n]PREFIX, not 
> > PREFIX.
> 
> Oops, thanks for having spotted this ! I'll fix that ASAP.

Thanks.

./danfe