svn commit: r332334 - in head/finance: . vanitygen

[Boris Samorodov]

01.11.2013 21:36, Ryan Steinmetz пишет:
> 
> On (11/01/13 18:25), Boris Samorodov wrote:
>> 01.11.2013 16:59, Ryan Steinmetz пишет:
>>>
>>> On (11/01/13 15:24), Boris Samorodov wrote:
>>>> Hi Ryan, All,
>>>>
>>>> 01.11.2013 05:12, Ryan Steinmetz пишет:
>>>>
>>>>> Log:
>>>>>   New port: finance/vanitygen:
>>>>
>>>> Thank you for working on new ports. It's always good to get a new one.
>>>> However there are some notes inlined.
>>>>
>>>>> +MAINTAINER=    ports at FreeBSD.org
>>>>
>>>> I'm not sure that a new unmaintained port is welcomed.
>>>>
>>>>> +COMMENT=    A standalone vanity address generator for bitcoin
>>>
>>> My bad on this, although, I had thought that portlint(1) would have
>>> caught
>>> this.
>>>
>>>> Articles should not be used at the beginning of a COMMENT.
>>>>
>>>>> +LIB_DEPENDS=    pcre:${PORTSDIR}/devel/pcre
>>>>
>>>> A new LIB_DEPENDS syntax is preferred.
>>>
>>> Do you have the announcement?  After digging a bit, the only thing I was
>>> able to find was the commit log.
>>
>> I'd say that it was discussed to death via wiki, mailing lists (no
>> link, sorry) and Handbook:
>> https://wiki.freebsd.org/ports/fix_lib_depends
>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html
>>
>>
> 
> So, no announcement. 

No, _I_ do not keep all announcements.

> That, in combination with portlint not being
> updated to validate the new style is going to create problems like this
> one.
> 
> I do not always have the opportunity to go back and read through all of
> the mailing lists/commit logs.
> 
>>>>> +NO_STAGE=    yes
>>>>
>>>> I think that new ports are supposed to support STAGE.
>>>
>>> I do not believe that Tinderbox supports STAGE, so I do not have a means
>>> of testing it at the moment.
>>
>> There is a very lightweight (only one dependency) ports-mgmt/poudriere.
>> It's very simple to install, configure and deploy.
>>
> 
> Still requires installation, configuration, etc.

It's your responsibility as a maintainer and/or committer.

All in all, I just tried to show you what you may do _if you want_.
No more, no less.

Good bye.
-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve