svn commit: r318973 - head/irc/weechat

[Alexey Dokuchaev]

On Fri, May 24, 2013 at 02:16:47PM +0000, Jase Thew wrote:
> New Revision: 318973
> URL: http://svnweb.freebsd.org/changeset/ports/318973
> 
> -COMMENT=	A lightweight and user friendly ncurse based IRC client
> +COMMENT=	A lightweight and user friendly ncurses based IRC client

Nice catch, but you could've also dropped leading article.

>  BACKTRACE_DESC=	Provide crash backtraces
>  CHARSET_DESC=	Charset conversion support
>  DOCUMENTATION_DESC=	Build and install documentation
> -GUILE_DESC=	Guile scripting support
>  LUA_DESC=	Lua scripting support
>  PERL_DESC=	Perl scripting support
>  PYTHON_DESC=	Python scripting support
>  RUBY_DESC=	Ruby scripting support
>  TCL_DESC=	Tcl scripting support
>  COLOR256_DESC=	Use ncurses port for 256 color support
> +ICON_DESC=	Desktop icon

Better knob description would be "Install desktop icon".

> +.if ${PORT_OPTIONS:MICON}
> +PLIST_SUB+=	ICON=""
> +.else
> +PLIST_SUB+=	ICON="@comment "
> +.endif

Hmm, if all it takes to install in icon is just pkg-plist change (that is,
no extra dependencies), does it really make much sense making it OPTIONal?

./danfe