svn commit: r317834 - head/astro/swe

Alexey Dokuchaev danfe at FreeBSD.org
Sat May 11 11:01:10 UTC 2013


On Sat, May 11, 2013 at 11:56:05AM +0200, Lars Engels wrote:
> On Sat, May 11, 2013 at 09:18:07AM +0000, Alexey Dokuchaev wrote:
> > On Fri, May 10, 2013 at 06:28:35PM +0000, Lars Engels wrote:
> > > New Revision: 317834
> > > URL: http://svnweb.freebsd.org/changeset/ports/317834
> > > 
> > > @@ -24,6 +24,10 @@ post-patch:
> > >  		-e 's|CFLAGS =|CFLAGS ?=|' \
> > >  		${WRKSRC}/Makefile
> > >  
> > > +.if ${OSVERSION} >= 100000
> > > +	@${REINPLACE_CMD} -e 's|-O9|-O3|' ${WRKSRC}/Makefile
> > > +.endif
> > 
> > Any reason for this fix being conditional on OSVERSION?
> 
> I assumed that -O9 didn't work with CLANG on current, but I just checked
> this and the port gets automatically build with -O2.
> I'll talk about it with the PR submitter if it's necessary.

It would be awesome if the port could be teached to uphold our CFLAGS
instead of using hardcoded (very bogus) -O9 or whatever.

./danfe


More information about the svn-ports-all mailing list