svn commit: r317806 - in head/archivers/unalz: . files
Alexey Dokuchaev
danfe at FreeBSD.org
Fri May 10 14:57:45 UTC 2013
On Fri, May 10, 2013 at 02:31:14PM +0000, Martin Wilke wrote:
> New Revision: 317806
> URL: http://svnweb.freebsd.org/changeset/ports/317806
>
> Log:
> - Fix build
>
> PR: 178154
> Submitted by: Ports Fury
While most of the Kato's work are of rather high quality and quite accurate
with the details down to licensing issues, this particular change:
> do-install:
> - ${INSTALL_PROGRAM} ${WRKSRC}/unalz ${PREFIX}/bin
> + (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)
is gratuitous and should not have been committed. I think I've previously
raise this concern with Kato's submissions before. Not just it does not win
us anything here, it makes install(1) statement context-dependent and also
reduces readability thereof at the same time.
No matter how good is Kato (whoever they are), we should not handle their
patches blindly.
./danfe
More information about the svn-ports-all
mailing list