svn commit: r317548 - head/lang/erlang

Alexey Dokuchaev danfe at FreeBSD.org
Tue May 7 01:40:34 UTC 2013


On Mon, May 06, 2013 at 08:18:33PM +0000, Jimmy Olgeni wrote:
> New Revision: 317548
> URL: http://svnweb.freebsd.org/changeset/ports/317548
> 
> Log:
>   Do not try to install empty DOCSDIR.
> 
> @@ -200,8 +200,8 @@ post-install:
>  	@${INSTALL_DATA} ${WRKSRC}/lib/dialyzer/doc/*.txt \
>  		${PREFIX}/lib/${ERLANG_LIB}/lib/dialyzer-*/doc/
>  
> -	@${MKDIR} ${DOCSDIR}
>  .for FILE in ${DOC_DISTFILES}
> +	@${MKDIR} ${DOCSDIR}
>  	@${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/$$(expr ${FILE} : '\([^:]*\)') ${DOCSDIR}
>  .endfor
>  .endif

I don't quite understand this change.  Why move mkdir inside the loop?
How is can be empty when the whole thing is already inside .if
${PORT_OPTIONS:MDOCS}?

The port itself could probably benefit from some cleaning and fixing of
several style bugs.

./danfe


More information about the svn-ports-all mailing list