svn commit: r317266 - head/multimedia/gst123

[Max Brazhnikov]

Hi,

On Fri, 03 May 2013 21:36:29 +0000Fri May  3 21:36:29 2013 Raphael Kubo da Costa wrote:
> Author: rakuco
> Date: Fri May  3 21:36:29 2013
> New Revision: 317266
> URL: http://svnweb.freebsd.org/changeset/ports/317266
> 
> Log:
>   Update to 0.3.2.
>   
>   PR:		ports/178226
>   Submitted by:	Herbert J. Skuhra <h.skuhra at gmail.com> (maintainer)
> 
> Modified:
>   head/multimedia/gst123/Makefile
>   head/multimedia/gst123/distinfo
> 
> Modified: head/multimedia/gst123/Makefile
> ==============================================================================
> --- head/multimedia/gst123/Makefile	Fri May  3 21:35:23 2013	(r317265)
> +++ head/multimedia/gst123/Makefile	Fri May  3 21:36:29 2013	(r317266)
> @@ -1,13 +1,8 @@
> -# New ports collection makefile for:	gst123
> -# Date created:				Wed December 8, 2010
> -# Whom:					Herbert J. Skuhra <h.skuhra at gmail.com>
> -#
> +# Created by: Herbert J. Skuhra <h.skuhra at gmail.com>
>  # $FreeBSD$
> -#
>  
>  PORTNAME=	gst123
> -PORTVERSION=	0.2.1
> -PORTREVISION=	1
> +PORTVERSION=	0.3.2
>  CATEGORIES=	multimedia
>  MASTER_SITES=	http://space.twc.de/~stefan/gst123/
>  
> @@ -20,13 +15,24 @@ GNU_CONFIGURE=	yes
>  USE_GMAKE=	yes
>  USE_BZIP2=	yes
>  USE_GNOME=	gtk20
> -USE_GSTREAMER=	good
>  CONFIGURE_ENV=	NCURSES5_CONFIG=/usr/bin/true
>  LDFLAGS+=	-lncurses
>  
>  PLIST_FILES=	bin/${PORTNAME}
>  MAN1=		${PORTNAME}.1
>  
> +OPTIONS_DEFINE=	GSTREAMER1
> +
> +GSTREAMER1_DESC=	Multimedia support via GStreamer 1.0 (instead of 0.10)
> +
> +.include <bsd.port.options.mk>
> +
> +.if ${PORT_OPTIONS:MGSTREAMER1} || exists(${LOCALBASE}/libdata/pkgconfig/gstreamer-1.0.pc)
> +USE_GSTREAMER1=	good
> +.else
> +USE_GSTREAMER=	good
> +.endif

Please avoid using 'exists($some_file)' for determining dependencies.
If there's no way to force building without gstreamer1 the option should be
removed in favour of hard dependence on gstreamer1.

Max