svn commit: r314866 - head/graphics/piddle

Alexey Dokuchaev danfe at FreeBSD.org
Fri Mar 22 01:56:09 UTC 2013


On Thu, Mar 21, 2013 at 07:53:16PM +0000, Beech Rintoul wrote:
> New Revision: 314866
> URL: http://svnweb.freebsd.org/changeset/ports/314866
> 
> +.if ${PORT_OPTIONS:MDOCS}
> +	(cd ${WRKSRC}/docs && ${COPYTREE_SHARE} \* ${DOCSDIR})

May I bring your attention one more time to the fact that using a dot
instead of asterisk has several advantages while achieving the same thing:

  - dot is not a subject to shell expansion, thus being generally safer
  - consequently, dot does not have to be escaped
  - dot is one character shorter and more readable (escaping commonly
    reduces readability in Unix constructs)

I think I've already made similar observations few days ago, which somehow
went unanswered.  If there's a flaw in my reasoning, please speak up, thanks!

./danfe


More information about the svn-ports-all mailing list