svn commit: r313125 - head/www/serf

[Raphael Eiselstein]

Hi Olli,

On Thu, Feb 28, 2013 at 08:32:20PM +0000, Olli Hauer wrote:
> Author: ohauer
> Date: Thu Feb 28 20:32:19 2013
> New Revision: 313125
> URL: http://svnweb.freebsd.org/changeset/ports/313125
> 
> Log:
>   - update to version 1.2.0

Something seems broken with 1.2.0. 

[root at fbsd9 /usr/ports/www/serf]# make install
===>  Installing for serf-1.2.0
===>   serf-1.2.0 depends on shared library: apr-1 - found
===>   Generating temporary packing list
===>  Checking if www/serf already installed
mkdir -p /usr/local/lib /usr/local/include/serf-1
/usr/local/libdata/pkgconfig
/usr/local/share/apr/build-1/libtool --silent --tag=CC --mode=install
/usr/bin/install -c -o root -g wheel -m 644 libserf-1.la /usr/local/lib
for i in serf.h serf_bucket_types.h serf_bucket_util.h; do \
        /usr/bin/install -c -o root -g wheel -m 644 ./$i
/usr/local/include/serf-1; \
done
/usr/bin/install -c -o root -g wheel -m 644 serf.pc
/usr/local/libdata/pkgconfig/serf-1.pc
/bin/mkdir -p /usr/local/share/doc/serf
install  -o root -g wheel -m 444
/var/tmp/usr/ports/www/serf/work/serf-1.2.0/design-guide.txt
/usr/local/share/doc/serf
===>   Running ldconfig
/sbin/ldconfig -m /usr/local/lib
===>   Registering installation for serf-1.2.0


[root at fbsd9 /usr/ports/www/serf]# make package
===>  Building package for serf-1.2.0
tar: include/serf-1/serf_private.h: Cannot stat: No such file or
directory
tar: Error exit delayed from previous errors.
pkg_create: make_dist: tar command failed with code 256
*** [do-package] Error code 1

Stop in /usr/ports/www/serf.

[root at fbsd9 /usr/ports/www/serf]# find /var/tmp/$PWD/work/ -name serf_private.h
/var/tmp//usr/ports/www/serf/work/serf-1.2.0/serf_private.h

[root at fbsd9 /usr/ports/www/serf]# find /usr/local/include/serf-1/ -name "*.h"
/usr/local/include/serf-1/serf_bucket_types.h
/usr/local/include/serf-1/serf_bucket_util.h
/usr/local/include/serf-1/serf.h

Yes, it is not installed (make install) but still in pkg_plist:

[root at fbsd9 /usr/ports/www/serf]# grep ^include pkg-plist
include/serf-1/serf.h
include/serf-1/serf_bucket_types.h
include/serf-1/serf_bucket_util.h
include/serf-1/serf_private.h

Is is just not needed anymore and pkg_plist has to be patched or is
"make install" just ignoring serf_private.h due to a bug?

From /var/tmp//usr/ports/www/serf/work/serf-1.2.0/Makefile:
[...]
HEADERS = serf.h serf_bucket_types.h serf_bucket_util.h
[...]

--> serf_private.h is not listed here and therefore not installed. "make
package" assumes to find include/serf-1/serf_private.h so my guess is
pkg_plist is wrong.

[root at fbsd9 /usr/ports/www/serf]# diff -u pkg-plist.orig pkg-plist
***********************************************************
--- pkg-plist.orig      2013-03-17 00:15:01.100699192 +0100
+++ pkg-plist   2013-03-17 00:15:12.899699867 +0100
@@ -1,7 +1,6 @@
 include/serf-1/serf.h
 include/serf-1/serf_bucket_types.h
 include/serf-1/serf_bucket_util.h
-include/serf-1/serf_private.h
 lib/libserf-1.a
 lib/libserf-1.la
 lib/libserf-1.so
***********************************************************

With this patch "make package" works but I don't know wether serf_private.h
is now just missing on my system or serf_private.h is obsolete(d).


Please review this wild guess as I'm not a programmer and just tried to
build my packages. 

Best regards
Raphael

-- 
Raphael Eiselstein <rabe at uugrn.org>               http://rabe.uugrn.org/
xmpp:freibyter at gmx.de  | https://www.xing.com/profile/Raphael_Eiselstein   
GnuPG:                E7B2 1D66 3AF2 EDC7 9828  6D7A 9CDA 3E7B 10CA 9F2D
.........|.........|.........|.........|.........|.........|.........|..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130317/ef56ccc3/attachment.sig>