svn commit: r314380 - head/graphics/colord

Koop Mast kwm at rainbow-runner.nl
Sat Mar 16 18:48:07 UTC 2013


On 16-3-2013 18:47, Alexey Dokuchaev wrote:
> On Sat, Mar 16, 2013 at 05:36:54PM +0000, Koop Mast wrote:
>> New Revision: 314380
>> URL: http://svnweb.freebsd.org/changeset/ports/314380
>>
>> Log:
>>    Prevert ! instead of empty() and fix a typo.
> It seems you've fixed typo in original submission, not in the Makefile. :)
> Could be confusing.
no take a closer look its a "empty(" and then closed with a "}", sneaky huh.

>
>> @@ -57,7 +57,7 @@ post-patch:
>>   		-e 's|-Wmissing-parameter-type||g' \
>>   		-e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \
>>   		${WRKSRC}/configure
>> -.if empty(PORT_OPTIONS:MMANPAGES}
>> +.if !${PORT_OPTIONS:MMANPAGES}
> It's usually better to pad ! with a space after it, helps to stand out.
>
> ./danfe
Ah I will try to keep that in mind for the next time.


More information about the svn-ports-all mailing list