svn commit: r314244 - head/graphics/synaesthesia

Alexey Dokuchaev danfe at FreeBSD.org
Fri Mar 15 03:53:54 UTC 2013


On Fri, Mar 15, 2013 at 02:48:55AM +0000, Beech Rintoul wrote:
> New Revision: 314244
> URL: http://svnweb.freebsd.org/changeset/ports/314244
> 
> +.if ${PORT_OPTIONS:MDOCS}
> +	@${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
> +PLIST_FILES+=	%%DOCSDIR%%/README
> +PLIST_DIRS+=	%%DOCSDIR%%

Why not move out these two lines out of .if (it looks very ugly and it's
generally bad idea to mix code with declarations) and turn them into
PORTDOCS (can be set unconditionally)?

I thought we had just discussed similar issue, like, yesterday. :)

./danfe


More information about the svn-ports-all mailing list