svn commit: r313841 - head/comms/openobex

[Guido Falsi]

On 03/15/13 00:54, Guido Falsi wrote:
> On 03/12/13 13:48, Eitan Adler wrote:
>> On 12 March 2013 07:18, Max Brazhnikov <makc at freebsd.org> wrote:
>>> On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote:
>>>> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote:
>>>>>>> Would it be feasible to make DOXYGEN default for bulk pacakge
>>>>>>> building
>>>>>>> cases but not for regular port users (that is, hide it behind
>>>>>>> BATCH or
>>>>>>> PACKAGE_BUILDING)?
>>>>>
>>>>> I do like your idea.
>>>>>
>>>>> I have tested the port with the following stanza after OPTIONS_DEFINE:
>>>>>
>>>>> .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
>>>>> OPTIONS_DEFAULT+=      DOXYGEN
>>>>> .endif
>>>>>
>>>>> It does work as expected, is this what you had in mind?
>>>>
>>>> Yes, exactly.
>>>>
>>>>> Should I check only against one of the two variables?
>>
>> Users will sometimes set BATCH to avoid interaction with the ports
>> tree.  I believe they would not expect it changes dependencies as
>> well.
>> PACKAGE_BUILDING seems more correct in this case.
>>
>
> My logic was inverted, rereading danfe statement he wants DOXYGEN on for
> PACKAGE_BUILDING and off for regular builds, like this:
>
> .if !defined(PACKAGE_BUILDING)
> OPTIONS_DEFAULT+=       DOXYGEN
> .endif

I still wrote it with inverted logic, I meant:

.if defined(PACKAGE_BUILDING)
OPTIONS_DEFAULT+=       DOXYGEN
.endif

-- 
Guido Falsi <madpilot at FreeBSD.org>