svn commit: r314117 - head/games/kye

Alexey Dokuchaev danfe at FreeBSD.org
Thu Mar 14 17:46:30 UTC 2013


On Thu, Mar 14, 2013 at 10:37:51AM -0700, Jason Helfman wrote:
> On Thu, Mar 14, 2013 at 9:57 AM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > Do you still disagree that PORTDOCS lines should be removed from pkg-plist
> > in favor of PORTDOCS set in the Makefile?
> 
> I completely agree with you, however since PLIST_SUB isn't doing anything
> in the Makefile, nor the pkg-plist, I really don't see the use for it. For
> some reason, the maintainer is using it, and I trusted that it had built
> fine per committer.

It's not about PLIST_SUB being in the Makefile, or pkg-plist, or anywhere :)
In fact, it's not about PLIST_SUB logic at all, it's perfectly fine.

The problem is that having *both* PORTDOCS being set in Makefile and the
very same docs listed in pkg-plist is wrong, and should be fixed, for the
obvious reasons.

./danfe


More information about the svn-ports-all mailing list