svn commit: r314117 - head/games/kye

[Alexey Dokuchaev]

On Thu, Mar 14, 2013 at 08:30:06AM -0700, Jason Helfman wrote:
> PORTDOCS make variable assignment is different then a PLIST_SUB. It also
> depends how it is used in the Makefile. In this instance, they are both
> used correctly.

PORTDOCS were introduced precisely to be able to off-load pkg-plist for
simple cases, like this one.  I really do not understand what point are
you trying to make here Jason, sorry.  For me it looks that ${TMPPLIST}
will now contain two copies of the docs, which upsets package deinstall.

If you still believe you're being right here, can you please explain:

- Why there are two instances of docs in .PLIST.mktmp, per simple grep?
- Why would anyone what to record docs twice (in PORTDOCS and pkg-plist)?
- Why do I see this:

$ make deinstall
===>  Switching to root credentials for 'deinstall' target
Password:
===>  Deinstalling for games/kye
===>   Deinstalling py27-kye-1.0_3
pkg_delete: file '/tmp/j/share/doc/kye/NEWS' doesn't exist
pkg_delete: file '/tmp/j/share/doc/kye/README' doesn't exist
pkg_delete: file '/tmp/j/share/doc/kye' doesn't exist
pkg_delete: unable to completely remove directory '/tmp/j/share/doc/kye'
pkg_delete: couldn't entirely delete package `py27-kye-1.0_3'
(perhaps the packing list is incorrectly specified?)
===>  Returning to user credentials

Do you still disagree that PORTDOCS lines should be removed from pkg-plist
in favor of PORTDOCS set in the Makefile?

./danfe