svn commit: r313841 - head/comms/openobex

[Guido Falsi]

On 03/11/13 15:04, Max Brazhnikov wrote:
> On Mon, 11 Mar 2013 01:31:56 +0000 Alexey Dokuchaev wrote:
>> On Sun, Mar 10, 2013 at 09:05:12PM +0000, Guido Falsi wrote:
>>> New Revision: 313841
>>> URL: http://svnweb.freebsd.org/changeset/ports/313841
>>>
>>> Log:
>>>    - Fix plist when DOXYGEN option is enabled but DOCS is not
>>>    - Enable DOXYGEN option by default
>>
>> Would it be feasible to make DOXYGEN default for bulk pacakge building
>> cases but not for regular port users (that is, hide it behind BATCH or
>> PACKAGE_BUILDING)?

I do like your idea.

I have tested the port with the following stanza after OPTIONS_DEFINE:

.if !defined(BATCH) && !defined(PACKAGE_BUILDING)
OPTIONS_DEFAULT+=      DOXYGEN
.endif

It does work as expected, is this what you had in mind? Should I check 
only against one of the two variables?

If the option is defined it will anyway enable the options, so it will 
not interfere with personalized tinderboxes.

>
> Sounds good. But not only doxygen is used to generate documentation, e.g. the
> doxygen port uses latex and graphviz to generate its own docs. We may consider
> introduce BUILD_DOCS option along with DOCS. The later should be used only for
> for installing files shipped with the source tarball, while the former would
> imply additional dependencies for generating documentation. Of cause it
> wouldn't be a problem to have BUILD_DOCS enabled for PACKAGE_BUILDING, until
> it's explicitly requested by user.
>

Not a bad idea at all. Especially for developer's documentation like 
doxygen generated ones.

-- 
Guido Falsi <madpilot at FreeBSD.org>