svn commit: r313372 - in head: devel/pecl-spread net/spread4 net/spread4/files

[Olli Hauer]

On 2013-03-05 20:01, Chris Rees wrote:
> On 3 March 2013 18:12, Olli Hauer <ohauer at freebsd.org> wrote:
> 
> <snip>
> 
>> +spread_cleanup() {
>> +       [ -f ${pidfile} ] && rm -f ${pidfile}
> 
> 
> Isn't checking a file exists rather redundant if you're going to use
> rm -f on it?
> 
> Chris
> 

Good catch,

I prefer checking for existence before deleting a file from a script
(instead using rm -f $var blindly) and a normal rm is sufficient here.

However I would avoid changing it now because I don't want to bump
PORTREVISION for such a change.

--
Regards,
olli