svn commit: r311324 - in head: . misc/amanda-server misc/amanda25-server misc/amanda26-server misc/amanda32-server misc/instant-server net-im/kpopup net-im/linpopup net/jags net/lanbrowsing net/pro...

[Eitan Adler]

On 31 January 2013 14:50, Bryan Drewery <bdrewery at freebsd.org> wrote:
> On 1/31/2013 1:14 PM, Timur I. Bakeyev wrote:
>>  .if defined (WITH_SAMBA)
>> -SAMBA_PORT?= samba34
>> +SAMBA_PORT?= samba36
>>  BUILD_DEPENDS+=      smbclient:${PORTSDIR}/net/${SAMBA_PORT}
>>  RUN_DEPENDS+=        smbclient:${PORTSDIR}/net/${SAMBA_PORT}
>> -CONFIGURE_ARGS+=     --with-smbclient=${PREFIX}/bin/smbclient
>> +CONFIGURE_ARGS+=     --with-smbclient=${LOCALBASE}/bin/smbclient
>
> Shouldn't PREFIX be respected and LOCALBASE just the default?

This diff is correct.  PREFIX is where samba will be installed to.
LOCALBASE refers to where things are already installed.   In this case
smbclient is a build and run depend, which means is already installed
(and therefore in LOCALBASE).

I wish the commit log were more clear.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams