svn commit: r310483 - in head/devel/tpasm: . files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Jan 16 10:03:31 UTC 2013


On Wed, Jan 16, 2013 at 08:17:53AM +0000, Marcelo Araujo wrote:
> New Revision: 310483
> URL: http://svnweb.freebsd.org/changeset/ports/310483
> 
> Log:
>   - Update to 1.8.
>   - Trim header.

I must say I see a lot of gratuitous changes that 1) do not seem to improve
anything (yet recude readability); and 2) are not mentioned in the log.

>   PR:		ports/174183
>   Submitted by:	KATO Tsuguru <tkato432 at yahoo.com>

Something unexpected from KATO-san. :(

>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)
>  	@${MKDIR} ${PREFIX}/libdata/${PORTNAME}
> -	${INSTALL_DATA} ${WRKSRC}/include/* ${PREFIX}/libdata/${PORTNAME}
> +	(cd ${WRKSRC}/include \
> +		&& ${INSTALL_DATA} * ${PREFIX}/libdata/${PORTNAME})
>  .if !defined(NOPORTDOCS)
>  	@${MKDIR} ${DOCSDIR}
> -	${INSTALL_DATA} ${WRKSRC}/CONVERSION_C166.TXT ${WRKSRC}/MANUAL.TXT \
> -		${WRKSRC}/README*.TXT ${DOCSDIR}
> +.for i in CONVERSION_C166.TXT MANUAL.TXT README*.TXT
> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${i} ${DOCSDIR})
> +.endfor
>  .endif
>  .if !defined(NOPORTEXAMPLES)
>  	@${MKDIR} ${EXAMPLESDIR}
> -	${INSTALL_DATA} ${WRKSRC}/samples/* ${EXAMPLESDIR}
> +	(cd ${WRKSRC}/samples && ${INSTALL_DATA} * ${EXAMPLESDIR})
>  .endif

I am referring to this particualr part of the patch.  I will probably fix it
later if I happen to touch this port again.

./danfe


More information about the svn-ports-all mailing list