svn commit: r309908 - head/textproc/docproj

[Hiroki Sato]

Glen Barber <gjb at FreeBSD.org> wrote
  in <201301032304.r03N40Mp002548 at svn.freebsd.org>:

gj> Author: gjb
gj> Date: Thu Jan  3 23:04:00 2013
gj> New Revision: 309908
gj> URL: http://svnweb.freebsd.org/changeset/ports/309908
gj>
gj> Log:
gj>   Unset WITH_JADETEX if not otherwise specified.
gj>
gj>   PR:		ports/174952
gj>   Submitted by:	markj
gj>   Approved by:	doceng (implicit), eadler (mentor)
gj>
gj> Modified:
gj>   head/textproc/docproj/Makefile
gj>
gj> Modified: head/textproc/docproj/Makefile
gj> ==============================================================================
gj> --- head/textproc/docproj/Makefile	Thu Jan  3 21:59:30 2013	(r309907)
gj> +++ head/textproc/docproj/Makefile	Thu Jan  3 23:04:00 2013	(r309908)
gj> @@ -53,7 +53,7 @@ RUN_DEPENDS+=	jade:${PORTSDIR}/textproc/
gj>  .if defined(JADETEX)
gj>  WITH_JADETEX=	${JADETEX}
gj>  .endif
gj> -WITH_JADETEX?=
gj> +WITH_JADETEX?=	no
gj>
gj>  .if defined(PACKAGE_BUILDING)
gj>  WITH_JADETEX=	yes

 Please revert this and convert it to OPTIONS_DEFINE instead.
 WITH_JADETEX=no by default makes explanations in files/JADETEX
 useless and is counterintuitive because a docproj package for
 releases has been built with WITH_JADETEX=yes for a long time.  Some
 more clean-ups are needed for consistency, but simply setting "no" by
 default is still problematic and solves nothing IMO.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130104/7705594c/attachment.sig>