svn commit: r312904 - head/net-im/imspector

[Marcelo Araujo]

2013/2/25 Ruslan Makhmatkhanov <cvs-src at yandex.ru>

> Hi,
>
> Marcelo Araujo wrote on 25.02.2013 08:35:
>
>  2013/2/25 Po-Chien Lin <pclin at freebsd.org>
>>
>>  Author: pclin
>>> Date: Mon Feb 25 04:25:37 2013
>>> New Revision: 312904
>>> URL: http://svnweb.freebsd.org/**changeset/ports/312904<http://svnweb.freebsd.org/changeset/ports/312904>
>>>
>>> Log:
>>>    - Add IPFW suuport [1] and enable it by default [2]
>>>    - Trim Makefile header [2]
>>>    - Remove invalid entry from MASTER_SITES
>>>    - Patch to fix clang compiling
>>>    - Tune pkg-plist to pet portlint(1)
>>>
>>>    PR:           ports/175765
>>>    Submitted by: Oleg_Sch <7zsfx at 7zsfx.info> [1]
>>>    Approved by:  Mikhail Tsatsenko <m.tsatsenko at gmail.com> (maintainer)
>>> [2]
>>>    Approved by:  swills (mentor)
>>>
>>>
>>>  Dear Po-Chien,
>>
>> For my eyes, it is pretty much strange when we have two lines of "Approved
>> by" or more then one line of Submitted by or wherever, usually we use only
>> one line, and something like bellow:
>>
>> Approve by:    Mikhail Tsatsenko <m.tsatsenko at gmail.com> (maintainer)
>>                        swills (mentor)
>>
>> An example to submit:
>>
>> PR:                   ports/1111 [1], ports/22222 [2], ports/33333 [3]
>>
>
> Will this line be expanded up to three gnats followups (with commit
> message) for three different pr's?
> If I recall correctly it was suggested to use exactly this form to make
> sure everything is right:
>
> PR:     ports/1111 [1]
> PR:     ports/22222 [2]
> PR:     ports/33333 [3]
>
> And I stick this style because of that reason.  Can anybody clarify (once
> again)?
>
>

Yes, would be great if we have more comments, because in the section 16.3
of committers guid[1] does not mention nothing about it.

[1] http://www.freebsd.org/doc/en/articles/committers-guide/article.html

Best Regards,
-- 
Marcelo Araujo
araujo at FreeBSD.org