svn commit: r312091 - in head/audio: . gtmixer

[Martin Wilke]

All your comments fixed except from the grammar feel free to fix it.

- Martin

+-----------------oOO--(_)--OOo-------------------------+
With best Regards,
       Martin Wilke (miwi_(at)_FreeBSD.org)

Mess with the Best, Die like the Rest

On Feb 12, 2013, at 8:28 PM, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:

> On Tue, Feb 12, 2013 at 10:05:44AM +0000, Martin Wilke wrote:
>> New Revision: 312091
>> URL: http://svnweb.freebsd.org/changeset/ports/312091
>> 
>> +PORTNAME=	gtmixer
>> +PORTVERSION=	1.0.2
>> +CATEGORIES=	audio
>> +MASTER_SITES=	http://github.com/svagner/gtmixer/archive/
>> +DISTNAME=	${PORTVERSION}
> 
> Perhaps USE_GITHUB could be used here?..
> 
>> +WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
>> +FETCH_ARGS=	-Fpr
> 
> ... which could also release you from setting FETCH_ARGS.  (Setting WRKSRC
> also looks weird, but I'm not sure yet if it can be omitted.)
> 
>> +do-install:
>> +	@${MKDIR} ${PREFIX}/share/gtmixer
>> +	@${CP} -r ${WRKSRC}/icons ${PREFIX}/share/gtmixer/
>> +	@${INSTALL_MAN} ${WRKSRC}/gtmixer.1 ${MAN1PREFIX}/man/man1
> 
> We do not mute installation commands (muting MKDIR is fine).
> 
>> +++ head/audio/gtmixer/pkg-descr	Tue Feb 12 10:05:43 2013	(r312091)
>> @@ -0,0 +1,4 @@
>> +GTMixer is a free, simple graphical mixer for FreeBSD.
>> +Based at GTK 2.0 Lib.
> 
> Bad grammar, bogus use of contraction and capitalization; also it seems port
> description could be augmented a bit.
> 
> ./danfe