svn commit: r312035 - head/audio/lame

[Dmitry Sivachenko]

On 12.02.2013, at 9:52, Eitan Adler <eadler at FreeBSD.org> wrote:

> On 12 February 2013 00:03, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> On Sun, Feb 10, 2013 at 05:23:55PM +0000, Alexander Leidinger wrote:
>>> New Revision: 312035
>>> URL: http://svnweb.freebsd.org/changeset/ports/312035
>>> 
>>> Log:
>>>  Add dependency to libiconv.
>> 
>> :)  I would say adding USE_ICONV is probably useless in cases like this one,
>> when it's getting pulled via other stuff.
> 
> If a port directly uses ICONV it must explicitly depend on it, and
> must not rely on indirect dependencies.
> 
> As for a PORTREVISION bump, this is more interesting:  I am inclined
> to bump because the "manifest" of the port changed.


There is nothing interesting here, you should definitely reread section 5.2.2.1 of Porter's handbook:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#makefile-naming-revepoch