svn commit: r335189 - in head/print/pdftk: . files

[Kozlov Sergey]

On Tue, Dec 10, 2013 at 7:48 PM, Gerald Pfeifer <gerald at pfeifer.com> wrote:
> On Tue, 10 Dec 2013, Kozlov Sergey wrote:
>> Yes, that's correct. I think the right solution is to add a check if
>> gcj is present and give an IGNORE with suggestion to rebuild gcc.
>
> Agreed.  If gcj is not present despite that dependency, that's a
> good idea.  Would you like to propose a patch?
>

Sure, working on it.

>>>    LIB_DEPENDS=      libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \
>>>              libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \
>>>              libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF}
>>>
>>> If you insist on libgcj.so, I can accept that, but then let's drop
>>> the other two least.  This is definitely covered by USE_GCC=yes.
>> USE_GCC doesn't add anything to RUN_DEPENDS.
>
> Sure it does:
>
>   .if defined(_GCC_PORT_DEPENDS)
>   BUILD_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
>   . if ${_USE_GCC} != 3.4
>   RUN_DEPENDS+=   ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT}
>   # Later GCC ports already depend on binutils; make sure whatever we
>   # build leverages this as well.
>   USE_BINUTILS=   yes
>   . endif
>   .endif

I've commented out the BUILD_DEPENDS and LIB_DEPENDS from the port,
leaving only USE_GCC and built it

root# make install
===>  Installing for pdftk-2.02
===>   pdftk-2.02 depends on executable: gcc46 - found
===>  Checking if print/pdftk already installed
===>   Registering installation for pdftk-2.02
Installing pdftk-2.02... done

Then I checked out portmaster output:

root# portmaster -l
===>>> Root ports (No dependencies, not depended on)
===>>> dialog4ports-0.1.5_2
===>>> gmake-3.82_1
===>>> libtool-2.4.2_2
===>>> pdftk-2.02
...
===>>> Leaf ports (Have dependencies, not depended on)
===>>> bison-2.7.1,1
===>>> gcc-4.6.4_1,1
===>>> 2 leaf ports

If gcc was installed as runtime dependency then pkg wouldn't let me
delete it without forcing

root# pkg delete binutils
pkg: Error while trying to delete packages, dependencies that are
still required:
devel/binutils: lang/gcc46

root# pkg delete gcc
Deinstallation has been requested for the following 1 packages:

        gcc-4.6.4_1,1

The deinstallation will free 567 MB

Proceed with deinstalling packages [y/N]:

I see the code in bsd.gcc.mk but it obviously doesn't work here
What am I doing wrong?

Best regards,
Kozlov Sergey