svn commit: r324380 - in head/sysutils/ipad_charge: . files

[Kevin Lo]

Alexey Dokuchaev wrote:
> On Thu, Aug 08, 2013 at 08:27:45AM +0000, Kevin Lo wrote:
>> New Revision: 324380
>> URL: http://svnweb.freebsd.org/changeset/ports/324380
>>
>> +.if ${OSVERSION} < 800000
>> +IGNORE=		requires FreeBSD 8.0-RELEASE or later
>>   .endif
> We no longer support old versions of FreeBSD like these.  Sometimes keeping
> some simple patch for a little longer is OK, but having the check merely for
> IGNORE message?.. better just kill it.
>
>> +post-install:
>> +	@${MKDIR} ${PREFIX}/etc/devd
>> +	@${SED} -e "s|%%PREFIX%%|${PREFIX}|g" \
>> +		< ${FILESDIR}/ipad_charge.conf.in > ${WRKDIR}/ipad_charge.conf
> Any reason why SUB_FILES was not used instead?
>
>> +	${INSTALL_DATA} "${WRKDIR}/ipad_charge.conf" ${PREFIX}/etc/devd
> Superfluous and inconsistent quotes.
>
>> +	@${CAT} ${PKGMESSAGE}
> It is better to pad pkg-message display with @${ECHO_CMD}'s on both sides
> to ensure consistent output (port vs. package).

All fixed now :-)  Thanks for pointing that out!

>
> ./danfe

     Kevin