svn commit: r316469 - head/databases/slony1v2

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-24 15:06:31 -0400, Chris Rees wrote:
> On 24 April 2013 19:59, Jung-uk Kim <jkim at freebsd.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote:
>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision:
>>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469
>>> 
>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be 
>>> conditional. - Whitespace fix.
>> ...
>> 
>> bsd.port.mk says "(PORTDOCS) should not be set when no
>> documentation files are installed" and I believe it is actually
>> correct.
> 
> That means "Don't set PORTDOCS unless you are going to install
> files to DOCSDIR".
> 
> This port does install files to DOCSDIR, except when !
> ${PORT_OPTIONS:MDOCS}

Therefore, it should be conditional. :-)

If you convert NOPORTDOCS to optionsNG, it should be optional because
bsd.port.mk does not know that, i.e.,

.if defined(PORTDOCS) && !defined(NOPORTDOCS)
...
.endif

Maybe we should fix bsd.port.mk, too.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJReC5yAAoJECXpabHZMqHOdywH/j+kPX2wL/ZIKXiuRMFRL51g
ch6noFBm7v43JuntoDqbp6NbTrB7Eq/Plno08nfmycE9OiBKtrOxM9k6wQ6OseTf
f5jbaU5vNmm4RfxUV1DfSFQd7nIfKTa38C1zrzDH3nr+SIMxe+nbu1nj7meJQQId
enABe1HykaUqrwkwgvuJmAW+XqxsJGlTjMDIdr6i9XK5ozEveE9RnMIraK+PULmo
aqypGG48Kj3flKMSzR6HyiVBuFSG4VVOVekXohG0AWDrtlm7zE5YhF8JYlDvglk1
jC4sFTCLiKRf3K93CkYpLp5Dtwa/e14sRfZz4Jn9dFLV861QJIl8Hy7o652/gb4=
=7/r2
-----END PGP SIGNATURE-----