svn commit: r48365 - user/jgh/committers-guide
Jason Helfman
jgh at FreeBSD.org
Thu Mar 10 17:49:07 UTC 2016
Author: jgh
Date: Thu Mar 10 17:49:06 2016
New Revision: 48365
URL: https://svnweb.freebsd.org/changeset/doc/48365
Log:
- wip
Modified:
user/jgh/committers-guide/article.xml
Modified: user/jgh/committers-guide/article.xml
==============================================================================
--- user/jgh/committers-guide/article.xml Thu Mar 10 10:18:54 2016 (r48364)
+++ user/jgh/committers-guide/article.xml Thu Mar 10 17:49:06 2016 (r48365)
@@ -3148,7 +3148,6 @@ Subscribers:<co xml:id="phabricator-subs
<procedure xml:id="phabricator-web-patch">
-
<step>
<para>Go to <link
xlink:href="https://reviews.freebsd.org/differential/">
@@ -3222,6 +3221,26 @@ Subscribers:<co xml:id="phabricator-subs
</procedure>
</sect2>
+
+ <sect2 xml:id="phabricator-address-revision">
+ <title>Address Revision Feedback</title>
+
+ <para>If a reviewer does not accept the change and asks
+ for a modification to the, edit the files in the local
+ client accordingly.</para>
+
+ <para>While doing so, fill in replies to any line-specific
+ comments that a reviewer may have left. Saving replies does
+ not cause them to be sent out. You must click the
+ <emphasis>Submit</emphasis> button for these to be sent
+ out.</para>
+
+ <para>After addressing all comments, upload the patch.
+ path should included all paths that are part of the review,
+ even if their contents haven't changed as part of this
+ update.</para>
+
+ </sect2>
</sect1>
<sect1 xml:id="people">
More information about the svn-doc-user
mailing list