PERFORCE change 211946 for review

Robert Watson rwatson at FreeBSD.org
Tue May 29 18:59:07 UTC 2012


http://p4web.freebsd.org/@@211946?ac=10

Change 211946 by rwatson at rwatson_svr_ctsrd_mipsbuild on 2012/05/29 18:58:21

	When printing page fault information for an unexpected exception
	type, explicitly print out "unknown" rather than an empty string,
	and include the exception type number for ease of debugging.

Affected files ...

.. //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 edit

Differences ...

==== //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 (text+ko) ====

@@ -1377,15 +1377,17 @@
 		read_or_write = "read";
 		break;
 	default:
-		read_or_write = "";
+		read_or_write = "unknown";
 	}
 
 	pc = frame->pc + (DELAYBRANCH(frame->cause) ? 4 : 0);
-	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault at %#jx\n",
+	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault "
+	    "(type %#x) at %#jx\n",
 	    msg, p->p_pid, p->p_comm,
 	    p->p_ucred ? p->p_ucred->cr_uid : -1,
 	    (intmax_t)pc,
 	    read_or_write,
+	    trap_type,
 	    (intmax_t)frame->badvaddr);
 
 	/* log registers in trap frame */


More information about the p4-projects mailing list