PERFORCE change 182898 for review

Hans Petter Selasky hselasky at freebsd.org
Wed Aug 25 19:28:06 UTC 2010


On Wednesday 25 August 2010 20:21:25 Garrett Cooper wrote:
> On Wed, Aug 25, 2010 at 9:49 AM, Hans Petter Selasky
> 
> <hselasky at freebsd.org> wrote:
> > http://p4web.freebsd.org/@@182898?ac=10
> > 
> > Change 182898 by hselasky at hselasky_laptop001 on 2010/08/25 16:49:00
> > 
> >        LibUSB:
> >                - patch for GNU/kFreeBSD by David Moles
> > 
> >        PR:            
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594330 Reviewed by:  
> >  hselasky @
> > 
> > Affected files ...
> > 
> > .. //depot/projects/usb/src/lib/libusb/libusb20.c#19 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/usb/src/lib/libusb/libusb20.c#19 (text+ko) ====
> > 
> > @@ -1182,7 +1182,7 @@
> >  {
> >        struct libusb20_backend *pbe;
> > 
> > -#ifdef __FreeBSD__
> > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> >        pbe = libusb20_be_alloc(&libusb20_ugen20_backend);
> >  #else
> >        pbe = NULL;
> 
> Crazy question... if GNU/kFreeBSD is going to be rebranding the kernel
> as __FreeBSD_kernel__, what about the rest of the references that are
> guarded by __FreeBSD__ ?
> Thanks,
> -Garrett

This check is not for checking if we are compiling in the kernel or not. It is 
only to check if we have a FreeBSD system kernel or not when compiling in 
userspace. Fortunately LibUSB only has one of these checks.

Was that your question?

--HPS


More information about the p4-projects mailing list