PERFORCE change 169116 for review

Scott Long scottl at FreeBSD.org
Fri Oct 2 01:58:50 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=169116

Change 169116 by scottl at scottl-y1 on 2009/10/02 01:58:39

	Reduce the scope of the locking in xpt_finishconfig_func.  The locking
	is wonky because of the device iteration code that needs to grab each
	SIM lock.

Affected files ...

.. //depot/projects/firewire/sys/cam/cam_xpt.c#3 edit

Differences ...

==== //depot/projects/firewire/sys/cam/cam_xpt.c#3 (text+ko) ====

@@ -4716,7 +4716,6 @@
 	struct	periph_driver **p_drv;
 	int	i;
 
-	mtx_lock(&xsoftc.xpt_lock);
 	if (busses_to_config == 0) {
 		/* Register all the peripheral drivers */
 		/* XXX This will have to change when we have loadable modules */
@@ -4733,11 +4732,12 @@
 		xpt_for_all_devices(xptpassannouncefunc, NULL);
 
 		/* Release our hook so that the boot can continue. */
+		mtx_lock(&xsoftc.xpt_lock);
 		wakeup(xpt_config);
+		mtx_unlock(&xsoftc.xpt_lock);
 	}
 
 	free(context, M_CAMXPT);
-	mtx_unlock(&xsoftc.xpt_lock);
 }
 
 static void


More information about the p4-projects mailing list