PERFORCE change 159969 for review
Edward Tomasz Napierala
trasz at FreeBSD.org
Sun Mar 29 04:38:23 PDT 2009
http://perforce.freebsd.org/chv.cgi?CH=159969
Change 159969 by trasz at trasz_victim7 on 2009/03/29 11:37:28
Remove VSYNCHRONIZE from VSTAT_PERMS.
Affected files ...
.. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#37 edit
.. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_subr.c#27 edit
.. //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#23 edit
Differences ...
==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#37 (text+ko) ====
@@ -245,9 +245,9 @@
/*
* XXX: PRIV_VFS_STAT?
*/
- if ((accmode & VSTAT_PERMS) &&
+ if ((accmode & (VSTAT_PERMS | VSYNCHRONIZE)) &&
!priv_check_cred(cred, PRIV_VFS_READ, 0))
- priv_granted |= VSTAT_PERMS;
+ priv_granted |= (VSTAT_PERMS | VSYNCHRONIZE);
if ((accmode & priv_granted) == accmode) {
if (privused != NULL)
==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_subr.c#27 (text+ko) ====
@@ -4304,7 +4304,7 @@
*accmode |= VADMIN;
}
- *accmode &= ~VSTAT_PERMS;
+ *accmode &= ~(VSTAT_PERMS | VSYNCHRONIZE);
if (*accmode == 0) {
*error = 0;
==== //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#23 (text+ko) ====
@@ -314,7 +314,6 @@
#define VWRITE 000000000200 /* write permission */
#define VREAD 000000000400 /* read permission */
#define VADMIN 000000010000 /* being the file owner */
-#define VSTAT 000000020000 /* permission to retrieve attrs */
#define VAPPEND 000000040000 /* permission to write/append */
/*
* VEXPLICIT_DENY makes VOP_ACCESS(9) return EPERM or EACCES only
@@ -344,7 +343,7 @@
/*
* Permissions that were traditionally granted to everyone.
*/
-#define VSTAT_PERMS (VSTAT | VREAD_ATTRIBUTES | VREAD_ACL | VSYNCHRONIZE)
+#define VSTAT_PERMS (VREAD_ATTRIBUTES | VREAD_ACL)
/*
* Permissions that allow to change the state of the file in any way.
More information about the p4-projects
mailing list