PERFORCE change 159923 for review

[Edward Tomasz Napierala]

http://perforce.freebsd.org/chv.cgi?CH=159923

Change 159923 by trasz at trasz_victim7 on 2009/03/27 20:18:17

	Formatting fixes.  Also, get rid of VALLPERMS; it's not used
	for anything.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#21 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#21 (text+ko) ====

@@ -310,33 +310,30 @@
 /*
  * Flags for accmode_t.
  */
-#define	VEXEC			000000000100	/* execute/search permission */
-#define	VWRITE			000000000200	/* write permission */
-#define	VREAD			000000000400	/* read permission */
-#define	VADMIN			000000010000	/* being the file owner */
-#define	VSTAT			000000020000	/* permission to retrieve attrs */
-#define	VAPPEND			000000040000	/* permission to write/append */
+#define	VEXEC			000000000100 /* execute/search permission */
+#define	VWRITE			000000000200 /* write permission */
+#define	VREAD			000000000400 /* read permission */
+#define	VADMIN			000000010000 /* being the file owner */
+#define	VSTAT			000000020000 /* permission to retrieve attrs */
+#define	VAPPEND			000000040000 /* permission to write/append */
 /*
- * Return EPERM or EACCES only if permission was denied explicitly,
- * by a "deny" rule in NFS4 ACL.  This never happens with ordinary
- * unix access rights or POSIX.1e ACLs.  Obviously, VEXPLICIT_DENY
- * must be OR-ed with some other Vflag.
+ * VEXPLICIT_DENY makes VOP_ACCESS(9) return EPERM or EACCES only
+ * if permission was denied explicitly, by a "deny" rule in NFS4 ACL,
+ * and 0 otherwise.  This never happens with ordinary unix access rights
+ * or POSIX.1e ACLs.  Obviously, VEXPLICIT_DENY must be OR-ed with
+ * some other V* constant.
  */
 #define	VEXPLICIT_DENY		000000100000
-#define	VREAD_NAMED_ATTRS 	000000200000	/* not used */
-#define	VWRITE_NAMED_ATTRS 	000000400000	/* not used */
+#define	VREAD_NAMED_ATTRS 	000000200000 /* not used */
+#define	VWRITE_NAMED_ATTRS 	000000400000 /* not used */
 #define	VDELETE_CHILD	 	000001000000
-#define	VREAD_ATTRIBUTES 	000002000000
-#define	VWRITE_ATTRIBUTES 	000004000000
+#define	VREAD_ATTRIBUTES 	000002000000 /* permission to stat(2) */
+#define	VWRITE_ATTRIBUTES 	000004000000 /* change {m,c,a}time */
 #define	VDELETE		 	000010000000
-#define	VREAD_ACL	 	000020000000
-#define	VWRITE_ACL	 	000040000000 
-#define	VWRITE_OWNER	 	000100000000
-#define	VSYNCHRONIZE	 	000200000000	/* not used */
-#define	VALLPERM	(VEXEC | VWRITE | VREAD | VADMIN | VSTAT | VAPPEND \
-    VEXPLICIT_DENY | VREAD_NAMED_ATTRS | VWRITE_NAMED_ATTRS | VDELETE_CHILD \
-    VREAD_ATTRIBUTES | VWRITE_ATTRIBUTES | VDELETE | VREAD_ACL | VWRITE_ACL \
-    VWRITE_OWNER | VSYNCHRONIZE)
+#define	VREAD_ACL	 	000020000000 /* read ACL and file mode */
+#define	VWRITE_ACL	 	000040000000 /* change ACL and/or file mode */
+#define	VWRITE_OWNER	 	000100000000 /* change file owner */
+#define	VSYNCHRONIZE	 	000200000000 /* not used */
 
 /*
  * Permissions that were traditionally granted only to the file owner.