PERFORCE change 155798 for review
Weongyo Jeong
weongyo at FreeBSD.org
Thu Jan 8 03:56:27 UTC 2009
http://perforce.freebsd.org/chv.cgi?CH=155798
Change 155798 by weongyo at weongyo_ws on 2009/01/08 03:55:24
As a looking of the Realtek's linux driver they use RX_MAXSIZE buffers
with 0x9c4(2500) but currently urtw(4) would use MCLBYTES. Without
datasheets it looks hard to define the value exactly. Just with some
testing it looks it's ok to use MCLBYTES but not sure there're some
side-effects.
So temporary remove a warning message to make users into confusions.
Affected files ...
.. //depot/projects/vap/sys/dev/usb/if_urtw.c#14 edit
Differences ...
==== //depot/projects/vap/sys/dev/usb/if_urtw.c#14 (text+ko) ====
@@ -669,7 +669,6 @@
goto fail;
}
if (fillmbuf) {
- /* XXX check maxsz */
dp->m = m_getcl(M_DONTWAIT, MT_DATA, M_PKTHDR);
if (dp->m == NULL) {
device_printf(sc->sc_dev,
@@ -734,9 +733,6 @@
urtw_alloc_rx_data_list(struct urtw_softc *sc)
{
- /* XXX todo */
- device_printf(sc->sc_dev, "WARNING: rx buffer is smaller than %d\n",
- URTW_RX_MAXSIZE);
return urtw_alloc_data_list(sc,
sc->sc_rxdata, URTW_RX_DATA_LIST_COUNT, MCLBYTES, 1 /* mbufs */);
}
More information about the p4-projects
mailing list